Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Update translations from Transifex #1391

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automated updates of translations pulled from Transifex

@github-actions github-actions bot force-pushed the chore/update-transifex branch from 8e13050 to 41b5f53 Compare December 1, 2024 20:29
"viewBeds": "Ver camas",
"wardAllocation": "Asignación de sala",
"wardAllocation": "Ward allocation",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher Is it normal that this string got updated because the default translation string got updated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is why we need to be very careful when updating the default translation string (Transifex is ultimately dumb, it can't tell if "Asignación de sala" is a good translation for both "Ward Allocation" and "Ward allocation", so it assumes that if the "baseline" translation is changing, the translation string needs to be updated). This needs to be fixed in Transifex before this is mergable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed upstream. Let's see what Transifex sends back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it's possible to manually trigger the job that pulls in changes.

@github-actions github-actions bot force-pushed the chore/update-transifex branch from 41b5f53 to 5b832af Compare December 3, 2024 20:31
@github-actions github-actions bot force-pushed the chore/update-transifex branch from 5b832af to e2aa4f1 Compare December 4, 2024 13:04
@ibacher ibacher merged commit b81da9d into main Dec 4, 2024
@ibacher ibacher deleted the chore/update-transifex branch December 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants